Fix Makefile export with Python 3 #8577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Python 3, the map() function returns a map object, not a list object as in Python 2. Ensure a list object is returned from format_flags() by wrapping map() in list(). This is compatible with both Python 2 and 3.
|
Thank you @lassebm for fix , we already assigned reviewers and will review it soon ! |
cmonr
approved these changes
Oct 31, 2018
|
/morph build |
Build : SUCCESSBuild number : 3523 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 3140 |
|
/morph mbed2-build |
Test : SUCCESSBuild number : 3307 |
|
@theotherjimmy , care to take a look? this really should only take a moment (tiny change) |
theotherjimmy
approved these changes
Nov 1, 2018
|
@NirSonnenschein Thanks for the ping. Feel free to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Python 3, the
map()function returns amapobject, not alistobject as inPython 2. Ensure a
listobject is returned fromformat_flags()by wrappingmap()inlist(). This is compatible with both Python 2 and 3.Regression in c777bd6.
Pull request type